ImageCache large images

The maxByteSize of the ImageCache is no longer automatically made larger to accommodate large images.

Previously, when loading images into the ImageCache that had larger byte sizes than the ImageCache's maxByteSize, Flutter permanently increased the maxByteSize value to accommodate those images. This logic sometimes led to bloated maxByteSize values that made working in memory-limited systems more difficult.

The following "before" and "after" pseudocode demonstrates the changes made to the ImageCache algorithm:

dart// Old logic pseudocode
void onLoadImage(Image image) {
  if (image.byteSize > _cache.maxByteSize) {
    _cache.maxByteSize = image.byteSize + 1000;
  }
  _cache.add(image);
  while (_cache.count > _cache.maxCount
      || _cache.byteSize > _cache.maxByteSize) {
    _cache.discardOldestImage();
  }
}

dart// New logic pseudocode
void onLoadImage(Image image) {
  if (image.byteSize < _cache.maxByteSize) {
    _cache.add(image);
    while (_cache.count > _cache.maxCount
        || _cache.byteSize > cache.maxByteSize) {
      cache.discardOldestImage();
    }
  }
}

There might be situations where the ImageCache is thrashing with the new logic where it wasn't previously, specifically if you load images that are larger than your cache.maxByteSize value. This can be remedied by one of the following approaches:

Increase the ImageCache.maxByteSize value to accommodate larger images.
Adjust your image loading logic to guarantee that the images fit nicely into the ImageCache.maxByteSize value of your choosing.
Subclass ImageCache, implement your desired logic, and create a new binding that serves up your subclass of ImageCache (see the image_cache.dart source).