Actions API revision
Summary
#In Flutter an Intent
is an object that's typically bound
to a keyboard key combination using the Shortcuts
widget.
An Intent
can be bound to an Action
,
which can update the application's state or perform other operations.
In the course of using this API, we identified several drawbacks
in the design, so we have updated the Actions API to make it easier
to use and understand.
In the previous Actions API design, actions were mapped from a
LocalKey
to an ActionFactory
that created a new
Action
each time the invoke
method was called.
In the current API, actions are mapped from the type of the Intent
to an Action
instance (with a Map<Type, Action>
),
and they are not created anew for each invocation.
Context
#The original Actions API design was oriented towards invoking actions from widgets, and having those actions act in the context of the widget. Teams have been using actions, and found several limitations in that design that needed to be addressed:
-
Actions couldn't be invoked from outside of the widget hierarchy. Examples of this include processing a script of commands, some undo architectures, and some controller architectures.
-
The mapping from shortcut key to
Intent
and then toAction
wasn't always clear, since the data structures mapped LogicalKeySet =>Intent and thenLocalKey
=>ActionFactory
. The new mapping is stillLogicalKeySet
toIntent
but then it mapsType
(Intent
type) toAction
, which is more direct and readable, since the type of the intent is written in the mapping. -
If the key binding for an action was in another part of the widget hierarchy, it was not always possible for the
Intent
to have access to the state necessary to decide if the intent/action should be enabled or not.
To address these issues, we made some significant changes to the API.
The mapping of actions was made more intuitive,
and the enabled interface was moved to the Action
class.
Some unnecessary arguments were removed from the Action
's
invoke
method and its constructor, and actions were allowed
to return results from their invoke method.
Actions were made into generics, accepting the type of Intent
they handle, and LocalKeys
were no longer used for identifying
which action to run, and the type of the Intent
is used instead.
The majority of these changes were made in the PRs for Revise Action API and Make Action.enabled be isEnabled(Intent intent) instead, and are described in detail in the design doc.
Description of change
#Here are the changes made to address the above problems:
- The
Map<LocalKey, ActionFactory>
that was given to theActions
widget is now aMap<Type, Action<Intent>>
(the type is the type of the Intent to be passed to the Action). - The
isEnabled
method was moved from theIntent
class to theAction
class. - The
FocusNode
argument toAction.invoke
andActions.invoke
methods was removed. - Invoking an action no longer creates a new instance of the
Action
. - The
LocalKey
argument to theIntent
constructor was removed. - The
LocalKey
argument toCallbackAction
was removed. - The
Action
class is now a generic (Action<T extends Intent>
) for better type safety. - The
OnInvokeCallback
used byCallbackAction
no longer takes aFocusNode
argument. - The
ActionDispatcher.invokeAction
signature has changed to not accept an optionalFocusNode
, but instead take an optionalBuildContext
. - The
LocalKey
static constants (named key by convention) inAction
subclasses have been removed. - The
Action.invoke
andActionDispatcher.invokeAction
methods now return the result of invoking the action as anObject
. - The
Action
class may now be listened to for state changes. - The
ActionFactory
typedef has been removed, as it is no longer used.
Example analyzer failures
#Here are some example analyzer failures that might be encountered where an outdated use of the Actions API might be the cause of the problem. The specifics of the error might differ, and there may be other failures caused by these changes.
error: MyActionDispatcher.invokeAction' ('bool Function(Action<Intent>, Intent, {FocusNode focusNode})') isn't a valid override of 'ActionDispatcher.invokeAction' ('Object Function(Action<Intent>, Intent, [BuildContext])'). (invalid_override at [main] lib/main.dart:74)
error: MyAction.invoke' ('void Function(FocusNode, Intent)') isn't a valid override of 'Action.invoke' ('Object Function(Intent)'). (invalid_override at [main] lib/main.dart:231)
error: The method 'isEnabled' isn't defined for the type 'Intent'. (undefined_method at [main] lib/main.dart:97)
error: The argument type 'Null Function(FocusNode, Intent)' can't be assigned to the parameter type 'Object Function(Intent)'. (argument_type_not_assignable at [main] lib/main.dart:176)
error: The getter 'key' isn't defined for the type 'NextFocusAction'. (undefined_getter at [main] lib/main.dart:294)
error: The argument type 'Map<LocalKey, dynamic>' can't be assigned to the parameter type 'Map<Type, Action<Intent>>'. (argument_type_not_assignable at [main] lib/main.dart:418)
Migration guide
#Significant changes area required to update existing code to the new API.
Actions mapping for pre-defined actions
#To update the action maps in the Actions
widget for
predefined actions in Flutter, like ActivateAction
and SelectAction
, do the following:
- Update the argument type of the
actions
argument - Use an instance of a specific
Intent
class in theShortcuts
mapping, rather than anIntent(TheAction.key)
instance.
Code before migration:
class MyWidget extends StatelessWidget {
// ...
@override
Widget build(BuildContext context) {
return Shortcuts(
shortcuts: <LogicalKeySet, Intent> {
LogicalKeySet(LogicalKeyboardKey.enter): Intent(ActivateAction.key),
},
child: Actions(
actions: <LocalKey, ActionFactory>{
Activate.key: () => ActivateAction(),
},
child: Container(),
)
);
}
}
Code after migration:
class MyWidget extends StatelessWidget {
// ...
@override
Widget build(BuildContext context) {
return Shortcuts(
shortcuts: <LogicalKeySet, Intent> {
LogicalKeySet(LogicalKeyboardKey.enter): ActivateIntent,
},
child: Actions(
actions: <Type, Action<Intent>>{
ActivateIntent: ActivateAction(),
},
child: Container(),
)
);
}
}
Custom actions
#To migrate your custom actions, eliminate the LocalKeys
you've defined, and replace them with Intent
subclasses,
as well as changing the type of the argument to the actions
argument of the Actions
widget.
Code before migration:
class MyAction extends Action {
MyAction() : super(key);
/// The [LocalKey] that uniquely identifies this action to an [Intent].
static const LocalKey key = ValueKey<Type>(RequestFocusAction);
@override
void invoke(FocusNode node, MyIntent intent) {
// ...
}
}
class MyWidget extends StatelessWidget {
// ...
@override
Widget build(BuildContext context) {
return Shortcuts(
shortcuts: <LogicalKeySet, Intent> {
LogicalKeySet(LogicalKeyboardKey.enter): Intent(MyAction.key),
},
child: Actions(
actions: <LocalKey, ActionFactory>{
MyAction.key: () => MyAction(),
},
child: Container(),
)
);
}
}
Code after migration:
// You may need to create new Intent subclasses if you used
// a bare LocalKey before.
class MyIntent extends Intent {
const MyIntent();
}
class MyAction extends Action<MyIntent> {
@override
Object invoke(MyIntent intent) {
// ...
}
}
class MyWidget extends StatelessWidget {
// ...
@override
Widget build(BuildContext context) {
return Shortcuts(
shortcuts: <LogicalKeySet, Intent> {
LogicalKeySet(LogicalKeyboardKey.enter): MyIntent,
},
child: Actions(
actions: <Type, Action<Intent>>{
MyIntent: MyAction(),
},
child: Container(),
)
);
}
}
Custom Actions
and Intents
with arguments
#To update actions that use intent arguments or hold state,
you need to modify the arguments to the invoke
method.
In the example below, the code keeps the value of the
argument in the intent as part of the action instance.
This is because in the old design there is a new instance
of the action created each time it's executed,
and the resulting action could be kept by the
ActionDispatcher
to record the state.
In the example of post migration code below,
the new MyAction
returns the state as the result
of calling invoke
, since a new instance isn't created
for each invocation. This state is returned to the caller of
Actions.invoke
, or ActionDispatcher.invokeAction
,
depending on how the action is invoked.
Code before migration:
class MyIntent extends Intent {
const MyIntent({this.argument});
final int argument;
}
class MyAction extends Action {
MyAction() : super(key);
/// The [LocalKey] that uniquely identifies this action to an [Intent].
static const LocalKey key = ValueKey<Type>(RequestFocusAction);
int state;
@override
void invoke(FocusNode node, MyIntent intent) {
// ...
state = intent.argument;
}
}
Code after migration:
class MyIntent extends Intent {
const MyIntent({this.argument});
final int argument;
}
class MyAction extends Action<MyIntent> {
@override
int invoke(Intent intent) {
// ...
return intent.argument;
}
}
Timeline
#Landed in version: 1.18
In stable release: 1.20
References
#API documentation:
Relevant issue:
Relevant PRs:
除非另有说明,本文档之所提及适用于 Flutter 的最新稳定版本,本页面最后更新时间: 2024-10-09。 查看文档源码 或者 为本页面内容提出建议。